Skip to content

Remove react from root package json #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: share-filter
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented Jul 7, 2025

Description

This PR refactors the project's dependency management by removing react, react-dom, react-router-dom, and their corresponding @types from the workspace root package.json. These dependencies are now installed directly within the individual applications and packages that explicitly require them.

This change reduces reliance on workspace-level React installations, promoting clearer and more granular dependency management per package.

Related Issue

N/A

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Jul 7, 2025

⚠️ No Changeset found

Latest commit: 055f475

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 7, 2025

Deploy Preview for module-federation-docs failed. Why did it fail? →

Name Link
🔨 Latest commit f068a43
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/686d11a1e506b0000839bdaf

@ScriptedAlchemy ScriptedAlchemy changed the base branch from main to share-filter July 8, 2025 12:40
- Add React import and type annotation to SSRLiveReload component
- Fix useRef to provide initial value as required by React 19 types
- Update @types/react to ^19.0.2 for React 19 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants